On Tue, Jun 19, 2012 at 06:48:51PM +0300, Radu Caragea wrote:
On Tue, Jun 19, 2012 at 6:31 PM, Daniel P. Berrange <berrange@redhat.com> wrote:
I tend to think it would be more flexible, if instead of just the prefix, we used the API to set the base module dir, eg
gvir_sandbox_config_initrd_set_moduledir("/lib/modules"); gvir_sandbox_config_initrd_set_moduledir("/some/other/prefix/lib/modules"); gvir_sandbox_config_initrd_set_moduledir("/some/other/dir")
and then just append the version string to that.
Daniel
Yes, I take your point. So basically the default moduledir should be "/lib/modules", the moddirpath corrected and the functions renamed a bit. But otherwise does it seem ok? I wasn't really sure about having a setter function both for the config and the initrd.
I think on GVirSandboxConfig we should have a 'kmodpath' property and gvir_sandbox_confijg_{get,set}_kmodpath() APIs. These would accept something like '/lib/modules'. On GVirSandboxConfigInitrd, we should hve a 'kmoddir' property and corresponding APIs. These would be given the full path eg '/lib/modules/x.y.z/kernel' THus the gvir_sandbox_builder_initrd_find_modules method would no longer need to figure out this path itself. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|