Re: [libvirt] [PATCH 1/8] Add new API virDomainSetBlockIoThrottle
On 10/27/2011 02:39 PM, Adam Litke wrote:
On Thu, Oct 27, 2011 at 05:20:03PM +0800, Lei HH Li wrote:
> This patch add new pulic API virDomainSetBlockIoThrottle to src/libvirt.c
> enable iotune setting for a device in domain XML.
You should include the API definition for both virDomainSetBlockIoThrottle and
virDomainGetBlockIoThrottle in the same patch. That way, reviewers can see the
complete picture of all API changes in one place.
Also, given the XML naming, these should be named
virDomain{Set,Get}BlockIoTune.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org