Re: [PATCH] nss: Finish renaming of HAVE_BSD_NSS macro

On Tue, Sep 01, 2020 at 11:26:58AM +0200, Michal Privoznik wrote: > When switching to meson, some of HAVE_* macros were renamed to > WITH_ because they did not reflect whether the build platform has > or doesn't have something, but whether we are building with some > functionality turned on or off. This is the case with > HAVE_BSD_NSS macro too. As a result, the NSS plugin built on BSD > did not expose nss_module_register() function which made the > plugin unusable: I've always thought the whole HAVE_ vs WITH_ distinction is a pretty arbitrary and unhelpful part of autoconf. Given this stat: $ git grep WITH_ | grep meson | wc -l 261 $ git grep HAVE_ | grep meson | wc -l 31 I think we should try to eliminate 100% of using of HAVE_ so that all our conditionals use WITH_