Re: [libvirt] [PATCH 2/8] systemd: don't report an error if the guest is already terminated

On 16.01.2015 18:36, Daniel P. Berrange wrote: > In many cases where we invoke virSystemdTerminateMachine the > process(es) will have already gone away on their own accord. > In these cases we log an error message that the machine does > not exist. We should catch this particular error and simply > ignore it, so we don't pollute the logs. > --- > src/util/virsystemd.c | 25 ++++++++++++++++++++----- > 1 file changed, 20 insertions(+), 5 deletions(-) > > diff --git a/src/util/virsystemd.c b/src/util/virsystemd.c > index 3eea5c2..29a2e63 100644 > --- a/src/util/virsystemd.c > +++ b/src/util/virsystemd.c > @@ -340,18 +340,22 @@ int virSystemdTerminateMachine(const char *name, > int ret; > DBusConnection *conn; > char *machinename = NULL; > + DBusError error; > + > + dbus_error_init(&error); This will suffer the same issue we already have in the code in virSystemdCreateMachine if libvirt is built without DBUS.