7:31 a.m.
RFC here:
https://www.redhat.com/archives/libvir-list/2018-May/msg02218.html
Since v1 [1]:
- remodeled egl-headless to be a standalone graphics element instead of a
result of some automagic with graphic's <gl> element
- pushed the first 5 simple fixes that were RB'd
- fixed some nits raised during review
Since v2 [2]
- converted the 'display' and 'egl-headless' PostParse callbacks in
patches 2
and 6 to Validate callbacks as they should have been since the beginning (see
the RFC)
- some minor nits
- added a standalone patch substituting some 'error' labels with 'cleanup'
as
requested during review
Since v3 [3]:
- all of the patches got a RB, but there were some comments that made me send
another version
- the only major change was to move the default 'display' choice from
qemu_command.c back to a PostParse callback, so now we format display='off' by
default to every domain that utilized an mdev
[1] https://www.redhat.com/archives/libvir-list/2018-June/msg01740.html
[2] https://www.redhat.com/archives/libvir-list/2018-July/msg00485.html
[3] https://www.redhat.com/archives/libvir-list/2018-July/msg00698.html
Erik Skultety (9):
qemu: qemuBuildHostdevCommandLine: Use a helper variable mdevsrc
qemu: caps: Introduce a capability for egl-headless
qemu: Introduce a new graphics display type 'headless'
qemu: caps: Add vfio-pci.display capability
conf: Introduce virDomainGraphicsDefHasOpenGL helper
conf: Replace 'error' with 'cleanup' in
virDomainHostdevDefParseXMLSubsys
conf: Introduce new <hostdev> attribute 'display'
qemu: command: Enable formatting vfio-pci.display option onto cmdline
docs: Update news about the VNC console enablement for mdevs
Katerina Koukiou (1):
docs: formatdomain: unify naming for CPUs/vCPUs
docs/formatdomain.html.in | 137 ++++++++++++------
docs/news.xml | 10 ++
docs/schemas/domaincommon.rng | 8 ++
src/conf/domain_conf.c | 106 +++++++++++---
src/conf/domain_conf.h | 5 +
src/libvirt_private.syms | 1 +
src/libxl/libxl_conf.c | 1 +
src/qemu/qemu_capabilities.c | 10 ++
src/qemu/qemu_capabilities.h | 4 +
src/qemu/qemu_command.c | 23 ++-
src/qemu/qemu_domain.c | 154 ++++++++++++++++++++-
src/qemu/qemu_driver.c | 2 +
src/qemu/qemu_hotplug.c | 1 +
src/qemu/qemu_process.c | 4 +
src/vmx/vmx.c | 1 +
tests/domaincapsschemadata/full.xml | 1 +
tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml | 1 +
tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml | 1 +
tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml | 1 +
tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml | 1 +
tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml | 1 +
tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml | 1 +
tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml | 2 +
tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml | 2 +
tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml | 2 +
tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml | 2 +
tests/qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 2 +
tests/qemucapabilitiesdata/caps_3.0.0.x86_64.xml | 2 +
tests/qemuxml2argvdata/graphics-egl-headless.args | 26 ++++
tests/qemuxml2argvdata/graphics-egl-headless.xml | 31 +++++
.../qemuxml2argvdata/graphics-sdl-egl-headless.xml | 35 +++++
.../graphics-spice-egl-headless.args | 31 +++++
.../graphics-spice-egl-headless.xml | 36 +++++
.../graphics-spice-invalid-egl-headless.xml | 37 +++++
.../graphics-vnc-egl-headless.args | 28 ++++
.../qemuxml2argvdata/graphics-vnc-egl-headless.xml | 37 +++++
.../hostdev-mdev-display-missing-graphics.xml | 35 +++++
...v-display-spice-egl-headless.x86_64-latest.args | 37 +++++
.../hostdev-mdev-display-spice-egl-headless.xml | 40 ++++++
...ev-mdev-display-spice-opengl.x86_64-latest.args | 36 +++++
.../hostdev-mdev-display-spice-opengl.xml | 41 ++++++
...dev-display-vnc-egl-headless.x86_64-latest.args | 37 +++++
.../hostdev-mdev-display-vnc-egl-headless.xml | 40 ++++++
.../hostdev-mdev-display-vnc.x86_64-latest.args | 36 +++++
.../qemuxml2argvdata/hostdev-mdev-display-vnc.xml | 39 ++++++
tests/qemuxml2argvdata/hostdev-mdev-display.xml | 39 ++++++
tests/qemuxml2argvtest.c | 24 ++++
.../graphics-spice-egl-headless.xml | 44 ++++++
.../graphics-vnc-egl-headless.xml | 42 ++++++
tests/qemuxml2xmloutdata/hostdev-mdev-display.xml | 47 +++++++
tests/qemuxml2xmltest.c | 3 +
51 files changed, 1214 insertions(+), 73 deletions(-)
create mode 100644 tests/qemuxml2argvdata/graphics-egl-headless.args
create mode 100644 tests/qemuxml2argvdata/graphics-egl-headless.xml
create mode 100644 tests/qemuxml2argvdata/graphics-sdl-egl-headless.xml
create mode 100644 tests/qemuxml2argvdata/graphics-spice-egl-headless.args
create mode 100644 tests/qemuxml2argvdata/graphics-spice-egl-headless.xml
create mode 100644 tests/qemuxml2argvdata/graphics-spice-invalid-egl-headless.xml
create mode 100644 tests/qemuxml2argvdata/graphics-vnc-egl-headless.args
create mode 100644 tests/qemuxml2argvdata/graphics-vnc-egl-headless.xml
create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-missing-graphics.xml
create mode 100644
tests/qemuxml2argvdata/hostdev-mdev-display-spice-egl-headless.x86_64-latest.args
create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-spice-egl-headless.xml
create mode 100644
tests/qemuxml2argvdata/hostdev-mdev-display-spice-opengl.x86_64-latest.args
create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-spice-opengl.xml
create mode 100644
tests/qemuxml2argvdata/hostdev-mdev-display-vnc-egl-headless.x86_64-latest.args
create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-vnc-egl-headless.xml
create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-vnc.x86_64-latest.args
create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-vnc.xml
create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display.xml
create mode 100644 tests/qemuxml2xmloutdata/graphics-spice-egl-headless.xml
create mode 100644 tests/qemuxml2xmloutdata/graphics-vnc-egl-headless.xml
create mode 100644 tests/qemuxml2xmloutdata/hostdev-mdev-display.xml
--
2.14.4