Re: [libvirt] [PATCH 3/3] m4: Check for rl_completion_quote_character

> So, one way to solve this once and for all would be to: > > * try looking up readline through pkg-config. If that works, > then we already know we're compiling against a recent > readline version and everything will work; > > * if readline's pkg-config file is not available, try linking > against it the old way. This will succeed on oldish versions > like the one shipped with CentOS but fail because of missing > functions on macOS. > > I could try cooking up something like the above, but I can never > seem to get it right the first couple of times when m4 is involved, > so in the interest of time - and not having to merge this patch you > hate ;) - would you mind looking into it yourself instead? The reason I hate this patch is not because the patch itself looks ugly. It's because we have to deal with the situation in the first place and invest our time in resolving it. And what you're suggesting might sound right but we'll end up with the same situation after all.