Re: [libvirt] [PATCH v2 1/3] virsh: Add keepalive in new vshConnect function

On 10.03.2014 12:26, Martin Kletzander wrote: > Introducing keepalive similarly to Guannan around 2 years ago. Since > we want to introduce keepalive for every connection, it makes sense to > wrap the connecting function into new virsh one that can deal > keepalive as well. > > Function vshConnect() is now used for connecting and keepalive added > in that function (if possible) helps preventing long waits e.g. while > nework goes down during migration. > > This patch also adds the options for keepalive tuning into virsh and > fails connecting only when keepalives are explicitly requested and > cannot be set (whether it is due to missing support in connected > driver or remote server). If not explicitely requested, a debug > message is printed (hence the addition to virsh-optparse test). > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1073506 > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=822839 > > Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com&gt; > --- > > Notes: > v2: > - Skip calling virConnectSetKeepAlive() when keepalive-inteval is set > to 0 > - Add keepalive-related options into virsh man page > - Just disable keepalive in virsh-optparse instead of checking for > the error. > > tests/virsh-optparse | 4 +-- > tools/virsh-domain.c | 2 +- > tools/virsh.c | 81 +++++++++++++++++++++++++++++++++++++++++++++++----- > tools/virsh.h | 5 ++++ > tools/virsh.pod | 12 ++++++++ > 5 files changed, 94 insertions(+), 10 deletions(-) ACK Michal