Re: [libvirt] [PATCH 1/2] qemu: Fix leak in qemuProcessInitCpuAffinity()
On Thu, 2019-06-06 at 06:44 -0400, John Ferlan wrote:
On 6/4/19 8:46 AM, Andrea Bolognani wrote:
> } else if (vm->def->cputune.emulatorpin) {
> - cpumapToSet = vm->def->cputune.emulatorpin;
> + if (virBitmapCopy(cpumapToSet, vm->def->cputune.emulatorpin) < 0)
Now Coverity is unhappy for another reason. What happens to the NULL
cpumapToSet when calling virBitmapCopy?
Should have been virBitmapNewCopy
Geez, so embarrassing :/
I just posted a fix:
https://www.redhat.com/archives/libvir-list/2019-June/msg00171.html
(sorry didn't get a chance to look at the patch when first
posted)
No need to apologize, but if you really feel like you need to make
up for it reviewing the above will do ;)
--
Andrea Bolognani / Red Hat / Virtualization