Re: [libvirt] [PATCH 1/3] cpu: define sub-leaf 0 for leaf 7 in cpu_map.xml

On Thu, Jun 29, 2017 at 03:11:41 +0200, Marek Marczykowski-Górecki wrote: > CPUID leaf 7 is sub-leaf aware. Add missing attribute. > --- > src/cpu/cpu_map.xml | 58 +++++++++++++++++++++++----------------------- > 1 file changed, 29 insertions(+), 29 deletions(-) > > diff --git a/src/cpu/cpu_map.xml b/src/cpu/cpu_map.xml > index 29b5b59..037a057 100644 > --- a/src/cpu/cpu_map.xml > +++ b/src/cpu/cpu_map.xml > @@ -195,93 +195,93 @@ > > <!-- cpuid function 0x7 ecx 0x0 features --> > <feature name='fsgsbase'> > - <cpuid eax_in='0x07' ebx='0x00000001'/> > + <cpuid eax_in='0x07' ecx_in='0' ebx='0x00000001'/> Why? Zero is the default value for ecx_in, I don't see a strong reason for mentioning it explicitly. If we do this, we should set the value to 0x00 though.