Re: [libvirt] [PATCH v2 3/6] tests: qemuxml2xml: Allow test cases to pass in qemuCaps
On 02/09/2016 10:58 AM, Cole Robinson wrote:
Similar to how we do it for qemuxml2argvtest. This will be used in
future
patches.
---
tests/qemuxml2xmltest.c | 27 ++++++++++++++++-----------
1 file changed, 16 insertions(+), 11 deletions(-)
My one problem with this patch is that the commit log uses "pass" in a
manner that the meaning is at first ambiguous (at first I thought "okay,
this allows the test cases to pass. But weren't they already passing?"
Then I reread and reparsed.) Maybe say "specify qemuCaps flags in test
cases" or something like that.
Otherwise makes sense (and the test cases *do* pass :-)
ACK.