Re: [RFC 4/6] migration: Deprecate -incoming <uri>

On 12/06/2023 21.33, Juan Quintela wrote: > Only "defer" is recommended. After setting all migation parameters, > start incoming migration with "migrate-incoming uri" command. > Signed-off-by: Juan Quintela <quintela(a)redhat.com&gt; > --- > docs/about/deprecated.rst | 7 +++++++ > softmmu/vl.c | 2 ++ > 2 files changed, 9 insertions(+) > diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst > index 47e98dc95e..518672722d 100644 > --- a/docs/about/deprecated.rst > +++ b/docs/about/deprecated.rst > @@ -447,3 +447,10 @@ The new way to modify migration is using migration parameters. > ``blk`` functionality can be acchieved using > ``migrate_set_parameter block-incremental true``. > +``-incoming uri`` (since 8.1) > +''''''''''''''''''''''''''''' > + > +Everything except ``-incoming defer`` are deprecated. This allows to > +setup parameters before launching the proper migration with > +``migrate-incoming uri``. > + > diff --git a/softmmu/vl.c b/softmmu/vl.c > index b0b96f67fa..7fe865ab59 100644 > --- a/softmmu/vl.c > +++ b/softmmu/vl.c > @@ -2651,6 +2651,8 @@ void qmp_x_exit_preconfig(Error **errp) > if (incoming) { > Error *local_err = NULL; > if (strcmp(incoming, "defer") != 0) { > + warn_report("-incoming %s is deprecated, use -incoming defer and " > + " set the uri with migrate-incoming.", incoming); > qmp_migrate_incoming(incoming, &local_err); > if (local_err) { > error_reportf_err(local_err, "-incoming %s: ", incoming); Could we maybe keep at least the smallest set of necessary parameters around? I'm often doing a "-incoming tcp:0:1234" for doing quick sanity checks with migration, not caring about other migration parameters, so if that could continue to work, that would be very appreciated.