On 09/18/2012 02:54 PM, Peter Krempa wrote:
On 09/18/12 21:55, Eric Blake wrote:
Commit 0fc89098 used functions only available on glibc, completely botched 32-bit environments, and risked SIGBUS due to unaligned memory access on platforms that aren't as forgiving as x86_64.
* bootstrap.conf (gnulib_modules): Import ffsl. * src/util/bitmap.c (includes): Use <strings.h> for ffsl. (virBitmapNewData, virBitmapToData): Avoid 64-bit assumptions and non-portable functions. ---
I wish I could push this under the build-breaker rule, but it is not quite trivial enough.
Indeed. Bit magic never was trivial :).
ACK. If there isn't a bug in my "brain simulation unit" then this should work as intended.
Thanks; pushed. With this, a cross-build to mingw gets further (it was failing for undefined functions, and now fails on: CC libvirt_util_la-virdbus.lo ../../src/util/virdbus.c: In function 'virDBusAddWatch': ../../src/util/virdbus.c:149:5: error: 'dbus_watch_get_fd' is deprecated (declared at /usr/include/dbus-1.0/dbus/dbus-connection.h:450) [-Werror=deprecated-declarations] -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org