Re: [libvirt] [PATCH 5/6] lxc: Create a method to initialize network data outisde.
$SUBJ:
lxc: Introduce lxcNetworkParseDataType
[see below for name change]
On 2/18/19 2:09 PM, Julio Faracco wrote:
This method has the same idea of the method to parse IPv{4,6} data.
The method lxcNetworkParseDataInit() is responsible to initialize
network settings outside handler.
Extract out the network "type" processing into it's own method
rather than inline within lxcNetworkParseDataSuffix.
Signed-off-by: Julio Faracco <jcfaracco(a)gmail.com>
---
src/lxc/lxc_native.c | 56 +++++++++++++++++++++++++-------------------
1 file changed, 32 insertions(+), 24 deletions(-)
diff --git a/src/lxc/lxc_native.c b/src/lxc/lxc_native.c
index 95e08c18f4..25e35e93dd 100644
--- a/src/lxc/lxc_native.c
+++ b/src/lxc/lxc_native.c
@@ -552,6 +552,37 @@ lxcAddNetworkDefinition(lxcNetworkParseData *data)
return -1;
}
+static int
+lxcNetworkParseDataInit(virConfValuePtr value, lxcNetworkParseData *parseData)
Similar w/r/t blank lines and 2 lines per argument
I think this is better named lxcNetworkParseDataType
Reviewed-by: John Ferlan <jferlan(a)redhat.com>
John
[...]