Re: [libvirt] [PATCH 2/2] conf: report an error message for non-existing USB hubs

On Mon, 2016-08-15 at 18:14 +0200, Ján Tomko wrote:

If any of the devices referenced a USB hub that does not exist, defining the domain would either fail with: error: An error occurred, but the cause is unknown (if only the last hub in the path is missing) or crash.

Return a proper error instead of crashing.

https://bugzilla.redhat.com/show_bug.cgi?id=1367130 --- src/conf/domain_addr.c | 8 ++++++++ .../qemuxml2argv-usb-hub-nonexistent.xml | 19 +++++++++++++++++++ tests/qemuxml2argvtest.c | 3 +++ 3 files changed, 30 insertions(+) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-hub-nonexistent.xml

ACK -- Andrea Bolognani / Red Hat / Virtualization