Re: [libvirt] [PATCH] cgroup.c: avoid unconditional leaks

4 Feb 2010


      According to Jim Meyering on 2/4/2010 3:16 AM:
...
Here's output from "git format-patch -U19 --stdout -1",
so you see the context:
     for (i = 0; i < ARRAY_CARDINALITY(inherit_values) ; i++) {
         char *value;
rc = virCgroupGetValueStr(parent,
                                   VIR_CGROUP_CONTROLLER_CPUSET,
                                   inherit_values[i],
                                   &value);
         if (rc != 0) {
             VIR_ERROR("Failed to get %s %d", inherit_values[i], rc);
             break;
         }
Is value allocated prior to that break?
...
VIR_DEBUG("Inherit %s = %s", inherit_values[i], value);
rc = virCgroupSetValueStr(group,
                                   VIR_CGROUP_CONTROLLER_CPUSET,
                                   inherit_values[i],
                                   value);
+        VIR_FREE(value);
Or is it only allocated by virCgroupSetValueStr.

-- 
Don't work too hard, make some time for fun as well!

Eric Blake             ebb9@byu.net