Re: [libvirt] [PATCH 08/12] storage_util: Split backing_fmt set in storageBackendCreateQemuImgOpts

On Tue, May 08, 2018 at 08:48:01 -0400, John Ferlan wrote:

The only way backing_fmts could be set is if the info->format was not RAW (see storageBackendCreateQemuImgSetBacking), so let's just extract it from the if/else surrounding the application of the encryption options.

Well, technically backingFmt and backing path only make sense for non-RAW disks. The condition below is weird though. The code was introduced by a combination of the commits adding LUKS support and then reverting the type. Given that prior to those commits it was indeed always executed, we can safely change it. ACK