Re: [libvirt] [PATCH]virsh: support readonly in attach-disk command
-----Original Message-----
From: Osier Yang [mailto:jyang@redhat.com]
Sent: Monday, October 14, 2013 4:48 PM
To: Chen Hanxiao
Cc: libvir-list(a)redhat.com
Subject: Re: [libvirt] [PATCH]virsh: support readonly in attach-disk
command
Not that simple, there is an option "--mode", accepts both
"shareable"
and "readonly".
also a standalone option "shareable", but I think it was a mistake.
Though it won't
cause problem since libvirt will ignore the multiple <shareable> tags
when parsing
the XML, if one specifies both --mode and --shareable like:
virsh attach-disk $dom --mode shareable --shareable ......
It will produce the the multiple <sharable> tags. I believe option
--print-xml will
tell the truth. T
I'm not clear why both "--mode" and "--shareable" were
introduced, but
apprrently
we should avoid more conflicts now.
I confused these too.
One could specify both "shareable" and "readonly"
in the meantime, but
option
"mode" doesn't support it yet. It's a problem. Though I don't like
the
"--mode",
since its meaning is too broad.
About using which option to support "readonly", "--mode" or
"--readonly", I don't
have strong opinion. But anyway, we should get the existing conflicts
solved first.
Thanks for your advice. I'll have a try.
Maybe option "--mode" is enough.
Osier