Re: [libvirt] [PATCH V2] add console support in libxl

On Thu, Jul 18, 2013 at 08:14:17PM +0800, Bamvor Jian Zhang wrote: > this patch introduce the console api in libxl driver for both pv and > hvm guest. and import and update the libxlMakeChrdevStr function > which was deleted in commit dfa1e1dd. > > Signed-off-by: Bamvor Jian Zhang <bjzhang(a)suse.com&gt; > --- > changes since V1: > 1), add virDomainOpenConsoleEnsureACL > 3), remove virReportOOMErrorFull when virAsprintf fail. > 4), change size_t for non-nagetive number in libxlDomainOpenConsole > size_t i; > size_t num = 0; > 5), fix for make check > (1), replace virAsprintf with VIR_STRDUP in two places > (2), delete space. > > src/libxl/libxl_conf.c | 88 ++++++++++++++++++++++++++++++++++ > src/libxl/libxl_conf.h | 3 ++ > src/libxl/libxl_driver.c | 122 +++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 213 insertions(+) > > > +static int > libxlMakeDomBuildInfo(virDomainDefPtr def, libxl_domain_config *d_config) > { > libxl_domain_build_info *b_info = &d_config->b_info; > @@ -403,6 +487,10 @@ libxlMakeDomBuildInfo(virDomainDefPtr def, libxl_domain_config *d_config) > if (VIR_STRDUP(b_info->u.hvm.boot, bootorder) < 0) > goto error; > > + if (def->nserials && > + (libxlMakeChrdevStr(def->serials[0], &b_info->u.hvm.serial) < 0)) > + goto error; > If you're going to hardcode def->serials[0], then you should explicitly report an error if 'def->nserials > 1'.

Also you should probably report an error if def->nparallels != 0, since you don't support that at all.