Re: [libvirt] [PATCH 08/41] remote: conditionalize daemon name in libvirtd daemon

On Fri, Jul 26, 2019 at 02:39:51PM +0200, Andrea Bolognani wrote: > On Tue, 2019-07-23 at 17:02 +0100, Daniel P. Berrangé wrote: > [...] > > +++ b/src/remote/remote_driver.h > > @@ -34,7 +34,6 @@ unsigned long remoteVersion(void); > > #define LIBVIRTD_PRIV_UNIX_SOCKET LOCALSTATEDIR "/run/libvirt/libvirt-sock" > > #define LIBVIRTD_PRIV_UNIX_SOCKET_RO LOCALSTATEDIR "/run/libvirt/libvirt-sock-ro" > > #define LIBVIRTD_USER_UNIX_SOCKET "libvirt-sock" > > -#define LIBVIRTD_CONFIGURATION_FILE SYSCONFDIR "/libvirt/libvirtd.conf" > > Oh, this was unused even before your changes, wasn't it? You should > drop it in a separate, trivial patch. No it was used, but this should have been done in patch 6 instead.