Re: [libvirt] [PATCH 7/8] tests: Introduce QEMU memory locking limit tests

27 Mar 2017

      On Mon, 2017-03-27 at 15:26 +0200, Martin Kletzander wrote:
[...]
...
...
+    if (!(cmd = qemuProcessCreatePretendCmd(conn, &driver, vm, NULL, 0, false,
+                                            VIR_QEMU_PROCESS_START_COLD))) {
+        goto cleanup;
+    }
+

Going through all this, just to check one number seems too much.  And it
doesn't actually test much more than simple call to
qemuDomainGetMemLockLimitBytes(def) would.
You're of course completely right :)

[...]
...
...
+int
+main(void)

Use different name (e.g. mymain) and VIRT_TEST_MAIN()
Done.

-- 
Andrea Bolognani / Red Hat / Virtualization