Re: [libvirt] [PATCH]: Fix "virsh attach-disk" and "virsh attach-interface"

5 Aug 2008


      Daniel P. Berrange wrote:
...
Ok, I've found the original xenDaemonAttachDevice() had this hack to make
them consistent:
if (!memcmp(sexpr, "(device ", 8)) {
        conf = sexpr + 8;
        *(conf + strlen(conf) -1) = 0; /* suppress final ) */
    }
    else
        conf = sexpr;
Which is just gross.
Ah, ug, that is gross.  Thanks for checking it out for me; I've committed this
patch now.

Chris Lalancette