Re: [libvirt] [PATCH] qemu: Set migration FD blocking

On 26.03.2013 17:08, Eric Blake wrote: > On 03/26/2013 08:55 AM, Michal Privoznik wrote: >> Since we switched from direct host migration scheme to the one, >> where we connect to the destination and then just pass a FD to a >> qemu, we have uncovered a qemu bug. Qemu expects migration FD to >> block. However, we are passing a nonblocking one which results in >> cryptic error messages like: >> >> qemu: warning: error while loading state section id 2 >> load of migration failed >> >> The bug is already known to Qemu folks, but we should workaround >> already released Qemus. Patch has been originally proposed by Stefan >> Hajnoczi <stefanha(a)gmail.com&gt; >> --- >> src/qemu/qemu_migration.c | 7 +++++++ >> 1 file changed, 7 insertions(+) > > Thanks for figuring it all out! I definitely hit this one, while trying > to help someone on IRC. > > ACK, and definitely 1.0.4 material. > Thanks, pushed to master. I wonder if it should be pushed to stable branches as well. Doug, Cole - what do you think?