On 05/17/2010 08:39 AM, Daniel P. Berrange wrote:
>> Where is WARN_LDFLAGS actually defined ? This looks like it
>> is just setting it to empty string ?
>
> Good catch. I'm squashing this in; do you need to see the revised patch
> before giving an ACK?
>
> diff --git i/acinclude.m4 w/acinclude.m4
> index f048879..8c97184 100644
> --- i/acinclude.m4
> +++ w/acinclude.m4
> @@ -78,6 +78,7 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[
> AC_MSG_RESULT($complCFLAGS)
>
> WARN_CFLAGS="$COMPILER_FLAGS $complCFLAGS"
> + WARN_LDFLAGS=$WARN_CFLAGS
> AC_SUBST([WARN_CFLAGS])
> AC_SUBST([WARN_LDFLAGS])
ACK, that's fine as an addition
Thanks; pushed as amended.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library
http://libvirt.org