Re: [PATCH v1] libxl: remove libxl_domain_create_info_init from libxlMakeDomCreateInfo

On 5/20/21 4:58 AM, Olaf Hering wrote:

The passed libxl_domain_create_info is owned, and already initialized, by the caller.

Signed-off-by: Olaf Hering <olaf@aepfle.de> --- src/libxl/libxl_conf.c | 2 -- 1 file changed, 2 deletions(-)

Reviewed-by: Jim Fehlig <jfehlig@suse.com

diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 8dc7e26cea..1fd0322b6a 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -129,8 +129,6 @@ libxlMakeDomCreateInfo(libxl_ctx *ctx, { char uuidstr[VIR_UUID_STRING_BUFLEN];

- libxl_domain_create_info_init(c_info); - if (def->os.type == VIR_DOMAIN_OSTYPE_HVM || def->os.type == VIR_DOMAIN_OSTYPE_XENPVH) { #ifdef WITH_XEN_PVH