On 9/11/25 01:38, Andrea Bolognani wrote:
On Wed, Sep 10, 2025 at 04:39:20PM -0600, Jim Fehlig wrote:
On 9/10/25 07:57, Andrea Bolognani via Devel wrote:
One of the new test cases demonstrates how firmware autoselection doesn't currently work correctly for domains using SEV-SNP: the descriptor for a suitable firmware exists, and yet it doesn't get picked up.
Another test cases shows that, while firmware autoselection succeeds for non-SNP SEV domains, the results are not the expected ones: the generic (stateful) edk2 build is used instead of the SEV-specific (stateless) one.
Sorry for not understanding how this test is useful in practice. I understand it shows autoselection results are not what's expected, but since the test passes, how would one know that?
By reading the commit message ;)
Again, this just establishes the baseline. By the end of the series, with firmware descriptors having been adjusted, firmware autoselection will yield the expected results. You can see that in patch 8.
Yes, had I looked. I stopped working for the day after patch 7 :-).
If you want, I can add a comment along the lines of
/* This succeeds, but the selected firmware is not the one * we want */
to qemuxmlconftest.c and drop it once descriptors are updated, for additional clarity.
I think that would be good, especially if the descriptor updates take time to land in Fedora, and 1-7 are pushed in the meantime. With that Reviewed-by: Jim Fehlig <jfehlig@suse.com> Regards, Jim