[libvirt PATCH v5 19/32] util: secure erase virCommand send buffers
All users of virCommandSetSendBuffer() are using it to send sensitive
data to a child process. So, since these buffers contain sensitive
information, clear it with virSecureErase().
Signed-off-by: Jonathon Jongsma <jjongsma(a)redhat.com>
---
src/util/vircommand.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/util/vircommand.c b/src/util/vircommand.c
index 0917bc9cfb..aef63efb26 100644
--- a/src/util/vircommand.c
+++ b/src/util/vircommand.c
@@ -54,6 +54,7 @@
#include "virpidfile.h"
#include "virprocess.h"
#include "virbuffer.h"
+#include "virsecureerase.h"
#include "virthread.h"
#include "virstring.h"
@@ -1672,6 +1673,7 @@ virCommandFreeSendBuffers(virCommand *cmd)
for (i = 0; i < virCommandGetNumSendBuffers(cmd); i++) {
VIR_FORCE_CLOSE(cmd->sendBuffers[i].fd);
+ virSecureErase(cmd->sendBuffers[i].buffer, cmd->sendBuffers[i].buflen);
VIR_FREE(cmd->sendBuffers[i].buffer);
}
VIR_FREE(cmd->sendBuffers);
--
2.39.1