Re: [libvirt] libvirtaio: libvirt-python asyncio event impl
On Thu, Mar 16, 2017 at 05:30:40PM +0100, Wojtek Porczyk wrote:
Hello, libvirt-list,
I wrote an event implementation wrapping an asyncio event loop [1].
I would like to contribute it back to libvirt-python, to be offered
alongside the Default Impl in C.
[1] https://github.com/woju/libvirtaio
Also it contains a workaround for a memory leak around the custom loop
implementation:
https://github.com/woju/libvirtaio/blob/8685cfc/libvirtaio.py#L66-L92
How should I submit this? As a patch against libvirt-python.git, appending to
libvirt-override.py?
IIUC, the asyncio module you're using is new in python 3.4 ? The libvirt
python code aims to be compatible with python >= 2.6 at this time, so
there's a mis-match there.
So if we did include that in the main libvirt python module, we'd have
to figure out a suitable approach to avoid trying to import the
non-existant module when people do "import libvirt".
Or we could just leave it as a standalone python module and document its
existence on our python binding page (http://libvirt.org/python.html)
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|