On 09/02/2011 03:57 AM, Daniel Veillard wrote:
On Thu, Sep 01, 2011 at 10:24:37PM -0600, Eric Blake wrote:
I think I've addressed most findings from round 3 - by implementing 9 : New flag in API, sensible, ACK 10 doesn't change default behaviour, looks fine, ACK 11 ACK 12 nasty, thanks for providing a new clean iterator, ACK 13 ACK 14 good, another iterator, ACK 15 implementation of 9/ for qemu, ACK 16 ACK 17 ACK 18 ACK 19 new API flags, ACK 20 ACK 21 virsh extensions, ACK 22 ACK 23 ACK 24 ACK 25 ACK unfortunately the half baked state of 0.9.4 is gonna remain for a while 26 ACK 27 I'm not so sure about that, as the caching is infinite. Some module rely on inotify already, and best would be to add an utility for inotify use and then use it on the dirs of $PATH, then upon change discard the cacher path I would push for now but add a TODO to fix that problem 28 ACK 29 Isn't there a way to save the domain snapshot on shared storage when available to try to avoid the problem ? It wouldn't work all the time but might be simpler than rolling out a v4. or consider the snapshot data as extra domain resource that could be migrated on the fly like we can do for disk images in some cases.
I've now pushed 9 and 15-29, for BZ 735457. I still have to figure out how to auto-clean snapshot metadata for transient domains, but that will have to be after patch 51 is in. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org