Re: [libvirt] [PATCH 6/7] Add sysinfo/smbios support to the QEmu driver
On Mon, Nov 08, 2010 at 01:28:06PM +0000, Daniel P. Berrange wrote:
On Fri, Nov 05, 2010 at 04:46:37PM +0100, Daniel Veillard wrote:
> + if (def->os.smbios_mode == VIR_DOMAIN_SMBIOS_HOST)
{
> + if (driver->hostsysinfo == NULL) {
> + qemuReportError(VIR_ERR_INTERNAL_ERROR,
> + _("Host SMBIOS informations are not
available"));
> + goto error;
> + }
This one should use VIR_ERR_CONFIG_UNSUPPORTED too, because we're just
saying that this data isn't available with qemu:///session instances
really.
Also s/informations are not/information is not/
[...]
ACK with those minor fixes
Okay I pushed the full patch set with this small fix,
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/