Re: [libvirt] [PATCH v4 01/13] Adapt to VIR_STRDUP and VIR_STRNDUP in src/conf/*

>> @@ -392,17 +392,14 @@ virCapabilitiesAddGuest(virCapsPtr caps, >> if (VIR_ALLOC(guest) < 0) >> goto no_memory; >> >> - if ((guest->ostype = strdup(ostype)) == NULL) >> + if (VIR_STRDUP(guest->ostype, ostype) < 0) >> goto no_memory; > > Local double-oom. You might want to clean this one up now. You mean s/no_memory/error/ ? Because even if the label is called no_memory not every label does call virReportOOMError(), like in this case.