Re: [libvirt] [PATCH] build: fix building with '--enable-test-locking'
On Wed, Dec 18, 2013 at 06:09:40AM -0700, Eric Blake wrote:
On 12/18/2013 02:35 AM, Martin Kletzander wrote:
> When test-locking is enabled, CFLAGS have -Dbool=char, which makes
Huh? bool should never be defined to char in CFLAGS; it should only be
replaced if gnulib thinks the compiler is too old.
> pipefd[bool] fail (obviously). Forcing the subscript to be bool by
> double negation fixes the build breaker.
I don't get how this could possibly make a difference. The 'output'
variable is declared bool, and then only ever assigned 'false' or
'true', which if bool is replaced by gnulib are still guaranteed to be 0
and 1, so using it directly as an array index is still safe.
>
> Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com>
> ---
>
> Notes:
> I still can't build with '--enable-test-locking' and I'm not
sure this
> is the proper way to fix it. Also, the code wasn't touched for
> months, so I'm not pushing it as a build-breaker.
NACK. I need more details about the actual failure you are seeing, but
this is not the right patch.
The reason for this is that CIL didn't understand the bool type.
GNULIB's automagic detection didn't help here because the build
is still done by gcc which supports it just fine. We use -save-temps
and then CIL analyses those intermediate files and threw up.
I'll see if it is still a problem on F20 CIL.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|