Re: [libvirt] [PATCH 14/16] snapshot: Move snapshot list code into generic file

On 3/20/19 1:41 AM, Eric Blake wrote: > Finish the code motion of generic moment list handling. Well, mostly - > we need to convert to using virObject to get polymorphic cleanup > functions (so for now there are still a few lingering ties specific to > snapshots). In this case, I kept virDomainSnapshotObjList as a > wrapper type around the new generic virDomainMomentObjList; the bulk > of the algorithms move, but the old functions remain and forward to > the generic helpers. > > Signed-off-by: Eric Blake <eblake(a)redhat.com&gt; > --- > src/conf/virconftypes.h | 3 + > src/conf/virdomainmomentobjlist.h | 32 +++ > src/conf/virdomainsnapshotobjlist.h | 6 - > src/conf/virdomainmomentobjlist.c | 356 ++++++++++++++++++++++++++++ > src/conf/virdomainsnapshotobjlist.c | 266 +++------------------ > 5 files changed, 422 insertions(+), 241 deletions(-)

I'll go with this even though it's not perfect - to some degree it may only be a name change or just technical debt promise of a future patch and of course review to do something. I'm not worried yet so much about the *AssignDef note, but it is something you may want to consider. Reviewed-by: John Ferlan <jferlan(a)redhat.com&gt;