Re: [libvirt] [PATCH 11/12] qemu: command: support -chardev for platform devices

7 Jul 2017


      On Mon, 2017-06-26 at 14:01 -0400, Cole Robinson wrote:
...
@@ -1877,8 +1877,8 @@ qemuProcessMonitorReportLogError(qemuMonitorPtr mon ATTRIBUTE_UNUSED,
  
  
  static int
-qemuProcessLookupPTYs(virDomainDefPtr def,
-                      virQEMUCapsPtr qemuCaps,
+qemuProcessLookupPTYs(virDomainDefPtr def ATTRIBUTE_UNUSED,
+                      virQEMUCapsPtr qemuCaps ATTRIBUTE_UNUSED,
                        virDomainChrDefPtr *devices,
                        int count,
                        virHashTablePtr info)
I don't see a reason to turn these into ATTRIBUTE_UNUSED,
just update the callers and get rid of them entirely.


Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

    