Re: [PATCH] virConnectAuthCallbackDefault: Return failure if 'virGetPassword' returns NULL

29 May 2025


      On Thu, May 29, 2025 at 22:43:20 +0200, Peter Krempa wrote:
...
From: Peter Krempa <pkrempa@redhat.com>
virGetPassword can return NULL on linux or BSD if it fails. The caller
in virConnectAuthCallbackDefault does dereference it unconditionally.
Return failure if virGetPassword returns NULL.
Fixes: db72866310d1e520efa8ed2d4589bdb5e76a1c95
Closes: https://gitlab.com/libvirt/libvirt/-/issues/777
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/libvirt.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>