On Tue, Jun 06, 2017 at 01:36:29PM +0200, Ján Tomko wrote:
Format iommu_platform= and ats= for virtio devices.
https://bugzilla.redhat.com/show_bug.cgi?id=1283251 --- src/qemu/qemu_capabilities.c | 12 ++++- src/qemu/qemu_capabilities.h | 2 + src/qemu/qemu_command.c | 58 ++++++++++++++++++++++ tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 2 + .../qemuxml2argv-virtio-options.args | 44 +++++++++------- tests/qemuxml2argvtest.c | 4 +- 6 files changed, 102 insertions(+), 20 deletions(-)
I've just realized that we format the iommu options only for some controller types or disk devices with bus="virtio". Shouldn't we check this in post parse callback and don't allow to specify the iommu options where it doesn't make sense? Otherwise the patch itself is good, so Reviewed-by: Pavel Hrdina <phrdina@redhat.com>