Re: [libvirt PATCH v4 09/31] qemu: query nbdkit module dir from binary
On Fri, Jan 20, 2023 at 16:03:03 -0600, Jonathon Jongsma wrote:
Rather than having NBDKIT_MODDIR as a build configuration option,
query
the nbdkit binary for the location to these directories. nbdkit provides
a --dump-config optiont that outputs this information and can be easily
parsed. We can also get the version from this output rather than
executing `nbdkit --version` separately.
Signed-off-by: Jonathon Jongsma <jjongsma(a)redhat.com>
---
meson.build | 6 ----
meson_options.txt | 1 -
src/qemu/qemu_nbdkit.c | 75 +++++++++++++++++++++++++++++++++---------
3 files changed, 60 insertions(+), 22 deletions(-)
You can use:
Reviewed-by: Peter Krempa <pkrempa(a)redhat.com>
On the detection code changes, wherever you place them.