On 10/25/2011 05:28 PM, Daniel P. Berrange wrote:
+int virConnectNumOfSavedImages (virConnectPtr conn); +int virConnectListSavedImages (virConnectPtr conn, + char **const files, + int maxfiles); +int virSavedImageRemove (virConnectPtr conn, + const char *file); +int virSavedImageDownload (virConnectPtr conn, + virStreamPtr stream, + const char *file);
THis looks very much like it is tending towards re-inventing most of the existing snapshot and/or managed save functionality.
I think one limitation of current managed save functionality is there can be at most 1 saved state file per domain. I'm not sure for snapshot, but looks like it's not supported for raw image, while save is.
@@ -1101,6 +1110,15 @@ int virDomainManagedSaveRemove(virDomainPtr dom, int virDomainCoreDump (virDomainPtr domain, const char *to, unsigned int flags); +int virConnectNumOfCoreDumps(virConnectPtr conn); +int virConnectListCoreDumps (virConnectPtr conn, + char **const files, + int maxfiles); +int virCoreDumpRemove (virConnectPtr conn, + const char *file); +int virCoreDumpDownload (virConnectPtr conn, + virStreamPtr stream, + const char *file);
This is slightly more palatable. IMHO we do want some kind of 'managed core dump' functionality to associate these APIs with, since we can't change the semantics of the existing virDOmainCoreDump API. ie we want something like
virDomainManagedCoreDump(virDomainPtr dom, int flags);
and now libvirt will pick the core dump filename, probably based on date.
Daniel
Maybe we can also have: virDomainManagedCoreDumpExt(virDomainPtr dom, int flags, char * id); To support more than one core dump files. Similar for managed save. IMHO, existing functionality is a little buggy, and there's already a bug for this: https://bugzilla.redhat.com/show_bug.cgi?id=746072 Thanks. Hong Xiang