Re: [libvirt] [PATCH v2 27/37] Adapt to VIR_STRDUP in src/vbox/*
On 04/29/2013 09:50 AM, Michal Privoznik wrote:
---
src/vbox/vbox_XPCOMCGlue.c | 4 +-
src/vbox/vbox_tmpl.c | 190 +++++++++++++++++++++++----------------------
2 files changed, 98 insertions(+), 96 deletions(-)
...
diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c
index 43ddac8..0e80194 100644
--- a/src/vbox/vbox_tmpl.c
+++ b/src/vbox/vbox_tmpl.c
... Oooh - I remember going through this one while doing Coverity work
- soooo many places where checks aren't made on memory allocations in
the UTF#_TO_UTF# macros and strdup()'s...
@@ -2957,6 +2960,7 @@ sharedFoldersCleanup:
PRUnichar *MACAddressUtf16 = NULL;
char *MACAddress = NULL;
char macaddr[VIR_MAC_STRING_BUFLEN] = {0};
+ int strdupRet = 0;
This doesn't get tagged by the syntax-check rule in 35/37?