Well, Eric, I've created a workbranch, maybe I need to do the rebase operation. I thought that's just ok to follow the steps where http://libvirt.org/hacking.html says: git checkout master git pull git checkout -t origin -b workbranch ...modify on workbranch... git pull --rebase ./autogen.sh ./configure --enable-werror make check make syntax-check make -C tests valgrind git pull --rebase git send-email ... Maybe I need to do a "git rebase -i orgin" before send-email, Right? So What should I do now? Modify the commit message and send again? Thanks. On 2013-09-17 23:04 , Eric Blake wrote: On 09/17/2013 08:57 AM, hzguanqiang@corp.netease.com wrote:
Please ignore the patchs [1-3]. I followed the contributer guidelines, before I push the patches I did a "git pull --rebase" operation, Then the newest three patches are included into my patches. Are there anything I missed?
That generally means you applied some patches locally without creating a new branch. If you want to discard non-upstream patches that are unrelated to what you are working on, you can do 'git rebase -i' (if your git version is too old, you might have to spell it 'git rebase -i origin'), and delete the lines for the patches you are no longer interested in. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------------------ Best regards! GuanQiang 23:06:36