Re: [libvirt] [dbus PATCH] AUTHORS: Update maintainers and original authors
On Wed, 2018-07-04 at 07:35 +0200, Pavel Hrdina wrote:
Create section for authors that started the project and add Katerina
into the list of primary maintainers.
Suggested-by: Andrea Bolognani <abologna(a)redhat.com>
Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com>
One day I will learn to check the list before posting patches O:-)
[...]
-The primary maintainers of libvirt-dbus are:
+The libvirt-dbus project was initiated by:
"Initiated" doesn't sound quite right in this context, what about
"started" (which, incidentally, you used in the commit message :)
or "created"?
[...]
Patches have been received from:
#authorslist#
Aside: right at the bottom of the file, we have
... send patches to get your name added ...
which seems quite useless to me, given that the list of
contributors is generated from the git log. I suggest dropping it,
but that's of course not in scope for this patch.
With the nit mentioned above fixed,
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
--
Andrea Bolognani / Red Hat / Virtualization