Re: [libvirt] [PATCH v2 0/3] libxl hooks

On 07/28/2016 05:57 AM, Cédric Bosdonnat wrote: > Hey there! > > Diffs to v1: > * move the ret = 0 to the proper patch > * fix typos as pointed by Joao > * use ignore_value where needed > > Cédric Bosdonnat (3): > libxl: add a flag to mark guests as tainted by a hook > libxl: fix segfault in libxlReconnectDomain > libxl: add hooks support > > docs/hooks.html.in | 53 ++++++++++++++++++++++++++-- > src/libxl/libxl_domain.c | 84 +++++++++++++++++++++++++++++++++++++++++++++ > src/libxl/libxl_domain.h | 2 ++ > src/libxl/libxl_driver.c | 52 +++++++++++++++++++++------- > src/libxl/libxl_migration.c | 57 ++++++++++++++++++++++++++++++ > src/util/virhook.c | 16 ++++++++- > src/util/virhook.h | 13 +++++++ > 7 files changed, 262 insertions(+), 15 deletions(-) > These patches were pushed, but are causing build failures (at least for me). I made sure to reset/clean my environment, but still many failures:

libxl/libxl_domain.c: In function 'libxlDomainCleanup': libxl/libxl_domain.c:1361:0: error: unterminated argument list invoking macro "ignore_value" } libxl/libxl_domain.c:808:9: error: 'ignore_value' undeclared (first use in this function) ignore_value(virHookCall(VIR_HOOK_DRIVER_LIBXL, vm->def->name, ^~~~~~~~~~~~ libxl/libxl_domain.c:808:9: note: each undeclared identifier is reported only once for each function it appears in libxl/libxl_domain.c:808:9: error: expected ';' at end of input libxl/libxl_domain.c:808:9: error: expected declaration or statement at end of input libxl/libxl_domain.c:805:15: error: unused variable 'xml' [-Werror=unused-variable] char *xml = virDomainDefFormat(vm->def, cfg->caps, 0); ^~~ libxl/libxl_domain.c:808:9: error: expected declaration or statement at end of input ignore_value(virHookCall(VIR_HOOK_DRIVER_LIBXL, vm->def->name, ^~~~~~~~~~~~ cc1: all warnings being treated as errors Makefile:8671: recipe for target 'libxl/libvirt_driver_libxl_impl_la-libxl_domain.lo' failed make[5]: *** [libxl/libvirt_driver_libxl_impl_la-libxl_domain.lo] Error 1 make[5]: *** Waiting for unfinished jobs.... libxl/libxl_driver.c: In function 'libxlDomainAttachDeviceLive': libxl/libxl_driver.c:3409:19: error: implicit declaration of function 'libxlDomainAttachControllerDevice' [-Werror=implicit-function-declaration] ret = libxlDomainAttachControllerDevice(driver, vm, dev->data.controller); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ libxl/libxl_driver.c:3409:13: error: nested extern declaration of 'libxlDomainAttachControllerDevice' [-Werror=nested-externs] ret = libxlDomainAttachControllerDevice(driver, vm, dev->data.controller); ^~~ libxl/libxl_driver.c: In function 'libxlDomainDetachDeviceLive': libxl/libxl_driver.c:3830:19: error: implicit declaration of function 'libxlDomainDetachControllerDevice' [-Werror=implicit-function-declaration] ret = libxlDomainDetachControllerDevice(driver, vm, dev); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ libxl/libxl_driver.c:3830:13: error: nested extern declaration of 'libxlDomainDetachControllerDevice' [-Werror=nested-externs] ret = libxlDomainDetachControllerDevice(driver, vm, dev); ^~~ cc1: all warnings being treated as errors Makefile:8678: recipe for target 'libxl/libvirt_driver_libxl_impl_la-libxl_driver.lo' failed