Re: [RFC PATCH 3/8] virshGraphicsAddressToString: Remove pointless translation
On Thu, Apr 13, 2023 at 11:23:18 +0200, Ján Tomko wrote:
On a Thursday in 2023, Peter Krempa wrote:
> There's no point in marking the protocol name as translatable.
>
> Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
> ---
> tools/virsh-domain-event.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/tools/virsh-domain-event.c b/tools/virsh-domain-event.c
> index 2ad4573ee9..1ed204fa9a 100644
> --- a/tools/virsh-domain-event.c
> +++ b/tools/virsh-domain-event.c
> @@ -211,15 +211,19 @@ virshGraphicsPhaseToString(int phase)
> VIR_ENUM_DECL(virshGraphicsAddress);
> VIR_ENUM_IMPL(virshGraphicsAddress,
> VIR_DOMAIN_EVENT_GRAPHICS_ADDRESS_LAST,
> - N_("IPv4"),
> - N_("IPv6"),
> - N_("unix"));
> + "IPv4",
> + "IPv6",
> + "unix");
>
"unix" is actually translated in our Korean translation.
I'm fairly sure that's wrong then since this is referring to the
protocol.