On 07/23/2013 09:21 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange" <berrange(a)redhat.com>
Convert the LXC driver code to use the new atomic API
for setup of cgroups
Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com>
---
src/lxc/lxc_cgroup.c | 53 +++++++++++++++---------------------------------
src/lxc/lxc_controller.c | 2 +-
2 files changed, 17 insertions(+), 38 deletions(-)
+ /*
+ * XXX
+ * We should pass the PID of the LXC init process
+ * not ourselves, but this requires some more
+ * refactoring. We should also pass the root dir
+ */
+ if (virCgroupNewMachine(def->name,
+ "lxc",
+ true,
+ def->uuid,
+ NULL,
+ getpid(),
The comment sounded a bit ominous about passing wrong information; but
as long as it's not permanently getting us into a setup where we can't
recover, but just represents an inefficiency, I don't think it hurts to
make incremental progress.
ACK.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library
http://libvirt.org