On 6/11/21 4:48 PM, Peter Krempa wrote:
This series consists of 3 parts:
Part 1, patches 1-3:
These are fixes to the virCommand->string conversion, namely two bugs:
- VIR_TEST_REGENERATE_OUTPUT would produce new files with missing end
newline
- memleak in bhyves xml->native conversion
Part 2, patches 4 - 21:
Removal of 's390-virtio' machine and the corresponding addressing
type. This was removed in qemu 2.6. The exploration started because
the last patch was for a strange reason checking the address type and
I needed to know if indeed 'virtio-s390' addresses don't support
iothreads. Turns out the whole thing can be deleted.
Part 3, patch 22:
Hotplug of disks with iothreads is broken because the code was moved
prior to address asignment and didn't account for missing address.
Let's remove the whole check as it turned out to be pointless.
[snip]
Looks good to me. A test drive also turned out fine.
Therefore for all patches of the series
Reviewed-by: Boris Fiuczynski <fiuczy(a)linux.ibm.com>
Thanks for cleaning up.
--
Mit freundlichen Grüßen/Kind regards
Boris Fiuczynski
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Gregor Pillen
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294