Re: [libvirt] [PATCH] build: fix up some compiler flags
On 05/16/2010 03:24 AM, Daniel P. Berrange wrote:
>
> * acinclude.m4 (LIBVIRT_COMPILE_WARNINGS): Define WARN_LDFLAGS as
> an alias for WARN_CFLAGS.
> +++ b/acinclude.m4
> @@ -78,7 +78,8 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[
> AC_MSG_RESULT($complCFLAGS)
>
> WARN_CFLAGS="$COMPILER_FLAGS $complCFLAGS"
> - AC_SUBST(WARN_CFLAGS)
> + AC_SUBST([WARN_CFLAGS])
> + AC_SUBST([WARN_LDFLAGS])
Where is WARN_LDFLAGS actually defined ? This looks like it
is just setting it to empty string ?
Good catch. I'm squashing this in; do you need to see the revised patch
before giving an ACK?
diff --git i/acinclude.m4 w/acinclude.m4
index f048879..8c97184 100644
--- i/acinclude.m4
+++ w/acinclude.m4
@@ -78,6 +78,7 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[
AC_MSG_RESULT($complCFLAGS)
WARN_CFLAGS="$COMPILER_FLAGS $complCFLAGS"
+ WARN_LDFLAGS=$WARN_CFLAGS
AC_SUBST([WARN_CFLAGS])
AC_SUBST([WARN_LDFLAGS])
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)