On Thu, 2016-04-14 at 18:59 +0100, Ian Jackson wrote:
Dario Faggioli writes ("Re: [Xen-devel] Fixing libvirt's libxl driver breakage -- where to define LIBXL_API_VERSION?"):
And, in those cases, usage should be gated by the appropriate LIBXL_HAVE_FOOBAR symbol, which I see in the sources (e.g., for LIBXL_HAVE_NO_SUSPEND_RESUME or LIBXL_HAVE_DOMAIN_NODEAFFINITY) to be the case, so good again. :-)
If libvirt specifies LIBXL_API_VERSION then it does not need to check any LIBXL_HAVE_*, since it will actually get an API corresponding to the specified API_VERSION.
I concur. And in fact, this patch introduces an LIBXL_API_VERSION and drops the use of LIBXL_HAVE_*. And I think the patch is right. :-) Regards, Dario -- <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)