On 10/25/2012 03:10 PM, Laine Stump wrote:
On 10/25/2012 11:18 AM, Peter Krempa wrote:
Until now, the network undefine API was able to undefine only inactive networks. The restriction doesn't make sense any more so this patch implements changing networks to transient. --- src/network/bridge_driver.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-)
(I *really* dislike the whole "def, newDef" way of doing things. I think there should be a "stateDef" and "configDef" instead, and they should be moved back and forth all the time - that just makes life confusing; configDef should always contain the persistent config (if it's a persistent network, or 0 otherwise) and stateDef should always contain the live state of the network (or 0 if its an inactive persistent network).
Indeed, that sounds like a saner way to do things, both for networks and for domains. Interesting refactoring project for anyone that wants to get their hands wet with libvirt internals :) -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org