Re: [libvirt] [PATCH 3/8] conf, qemu: Add support for shmem model

On 09/27/2016 08:24 AM, Martin Kletzander wrote: > Just the default one now, new ones will be added in following commits. > > Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com&gt; > --- > docs/schemas/domaincommon.rng | 9 +++++ > src/conf/domain_conf.c | 44 +++++++++++++++++------ > src/conf/domain_conf.h | 8 +++++ > src/libvirt_private.syms | 2 ++ > src/qemu/qemu_command.c | 11 +++++- > tests/qemuxml2argvdata/qemuxml2argv-shmem.xml | 2 ++ > tests/qemuxml2xmloutdata/qemuxml2xmlout-shmem.xml | 8 +++++ > 7 files changed, 72 insertions(+), 12 deletions(-) > docs/formatdomain.html.in ?? Just so I'm sure I understand ;-)... This is the existing 'model type' for 'shmem' being implemented as the "default" (e.g. 0 entry) because we know at some short time in the future we're going to be adding a new type (or two). Since the <model type='ivshmem'> is now going to be the default on output, we should explain in some way... and encourage choosing something else because "at some point in the future" ;-) we'll deprecate this one (whenever that dire time exists who knows). Making sure #2 - we don't have to care about save files, true? Since the default will be to now to ShmemDefFormat the <model> - a save file read on an older libvirt will have a failure, but that'd be true for any XML change I suppose.