Re: [libvirt] [PATCHv4 13/15] build: switch --with-qemu default from yes to check

On Mon, 2018-07-23 at 09:27 +0200, Andrea Bolognani wrote: > On Fri, 2018-07-20 at 11:33 +0100, Daniel P. Berrangé wrote: > > On Fri, Jul 20, 2018 at 12:24:50PM +0200, Ján Tomko wrote: > > > I do not oppose reverting this bit and failing by default if we don't > > > have a JSON library (as Andrea mentioned, more drivers might possibly > > > require a working JSON implementation). > > > > We use virjson.h throughout src/util and src/rpc so that code is > > not even driver specific, however, there are not currently mingw > > pacakges for jansson in Fedora at least. Maybe it will work, but > > we would need someone todo the work to add that to Fedora before > > we can consider making this mandatory. > > So does the MinGW build work at all without jansson, considering its > functionality is fairly reduced in scope compared to the Unix builds? Partially answering myself (morning coffee hasn't quite kicked in just yet), the MinGW .spec doesn't list yajl as a BuildRequires, which means that either we're not hitting any of the code paths you mention on that platform, or we've been producing completely useless Windows builds for a while now :)