Re: [libvirt] [PATCH v3 18/18] qemu: Defer support checks for external active snapshots to blockdev code or qemu

On Tue, Sep 03, 2019 at 04:08:11PM +0200, Peter Krempa wrote:

Remove libvit's support check for the target of an external snapshot to

Oh, you haven't applied my review feedback from v1 :) (That is: s/libvit/libvirt/)

the blockdev code or qemu. This will potentially require a more complex cleanup but removes a level of hardcoded feature checks.

Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com> --- src/qemu/qemu_driver.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-)

Reviewed-by: Ján Tomko <jtomko@redhat.com> Jano